Internal: Fix filters would not update and empty values break render [ED-20053]#31869
Merged
RobiFerentz merged 1 commit intomainfrom Jul 15, 2025
Merged
Internal: Fix filters would not update and empty values break render [ED-20053]#31869RobiFerentz merged 1 commit intomainfrom
RobiFerentz merged 1 commit intomainfrom
Conversation
Contributor
Elementor BuildLast updated at: 20250715.0726 ✅ Elementor build is ready for download. You can download the latest build from the link below: 🔗 elementor-3.31.0-20250715.0726.zip The build is available for 3 days. |
davseve
reviewed
Jul 15, 2025
packages/packages/libs/editor-controls/src/controls/filter-repeater-control.tsx
Outdated
Show resolved
Hide resolved
| let newValue = structuredClone( nVal ); | ||
| const newFuncName = newValue?.func.value ?? ''; | ||
| if ( meta?.bind === 'func' ) { | ||
| newValue = structuredClone( filterConfig[ newFuncName ].defaultValue.value ); |
Contributor
There was a problem hiding this comment.
what if newFuncName will be '' in this case?
Contributor
There was a problem hiding this comment.
it could be 2 times structuredClone with rewriting newValue
Contributor
Author
There was a problem hiding this comment.
That's for typescript only, there option does not actually exists in the options drop down. It's only valid names, no empty strings or nulls etc.
mykytamurzin
approved these changes
Jul 15, 2025
davseve
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.