Tweak: Add settings customization to the export process [ED-19808]#31853
Merged
ManorHazaz merged 27 commits intoelementor:mainfrom Jul 15, 2025
Merged
Tweak: Add settings customization to the export process [ED-19808]#31853ManorHazaz merged 27 commits intoelementor:mainfrom
ManorHazaz merged 27 commits intoelementor:mainfrom
Conversation
…to tweak/ED-19808-settings-cust
max-zu
reviewed
Jul 14, 2025
Comment on lines
+9
to
+14
| const [ dialogOpenItems, setDialogOpenItems ] = useState( () => { | ||
| return kitContentData.reduce( ( acc, item ) => { | ||
| acc[ item.type ] = false; | ||
| return acc; | ||
| }, {} ); | ||
| } ); |
Contributor
There was a problem hiding this comment.
if only 1 section can be expanded/opened at the moment - let's simplify it
const [ expandedSection, setSection ] = useState(null);
and use some sort of simple map in the code
const KIT_CUSTOMIATION_DIALOG = {
'site-settings': <KitSettingsCustomizationDialog />
}
Contributor
Author
There was a problem hiding this comment.
Good catch
Simplified
max-zu
reviewed
Jul 14, 2025
| </DialogHeader> | ||
|
|
||
| <DialogContent dividers sx={ { p: 3 } }> | ||
| <Stack spacing={ 0 }> |
Contributor
There was a problem hiding this comment.
isn't 0 the default value ?
Comment on lines
+1
to
+5
| { | ||
| "content": [], | ||
| "settings": { | ||
| "template": "default", | ||
| "body_background_background": "classic", |
Contributor
Author
There was a problem hiding this comment.
No, pushed by mistake
| } | ||
|
|
||
| $manifest_data['site-settings'] = $kit_tabs; | ||
| $manifest_data['site-settings'] = array_fill_keys( self::allowed_settings, true ); |
Contributor
There was a problem hiding this comment.
does import work correctly with this change ?
Contributor
Author
There was a problem hiding this comment.
Maybe not, but I added adaptor so maybe we will need to fix it
I don't want to it in that PR as well :|
…to tweak/ED-19808-settings-cust
…to tweak/ED-19808-settings-cust
…to tweak/ED-19808-settings-cust
max-zu
previously approved these changes
Jul 15, 2025
max-zu
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
Purpose: Add settings customization dialog to enable granular control of exported settings in the Import/Export module
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀