Skip to content

Internal: Fix control with missing variable [ED-19727]#31833

Merged
mike-elementor merged 8 commits intoelementor:mainfrom
mike-elementor:internal/ED-19727-control-with-missing-variable
Jul 14, 2025
Merged

Internal: Fix control with missing variable [ED-19727]#31833
mike-elementor merged 8 commits intoelementor:mainfrom
mike-elementor:internal/ED-19727-control-with-missing-variable

Conversation

@mike-elementor
Copy link
Copy Markdown
Contributor

@mike-elementor mike-elementor commented Jul 13, 2025

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

✨ PR Description

Purpose: Fix controls with missing variables by implementing proper error handling and UI components instead of throwing exceptions.
Main changes:

  • Added MissingVariable UI component with alert and warning indicators for variables that no longer exist
  • Replaced error throwing with graceful handling in ColorVariableControl and FontVariableControl
  • Added unit tests to validate behavior with missing variables

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@max-zu max-zu closed this Jul 13, 2025
Ntnelbaba
Ntnelbaba previously approved these changes Jul 13, 2025
gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

@mike-elementor mike-elementor merged commit 5cb0655 into elementor:main Jul 14, 2025
29 checks passed
@mike-elementor mike-elementor deleted the internal/ED-19727-control-with-missing-variable branch July 14, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants