Skip to content

Internal: Refactor css filter functions to make indicators work properly in editor [ED-19875]#31829

Merged
RobiFerentz merged 2 commits intomainfrom
ED-19875_refactor_filter_functions_make_indicators_great_again
Jul 13, 2025
Merged

Internal: Refactor css filter functions to make indicators work properly in editor [ED-19875]#31829
RobiFerentz merged 2 commits intomainfrom
ED-19875_refactor_filter_functions_make_indicators_great_again

Conversation

@RobiFerentz
Copy link
Copy Markdown
Contributor

@RobiFerentz RobiFerentz commented Jul 13, 2025

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

Refactor css filter functions to make indicators work properly in editor.

Description

Refactor css filter functions to make indicators work properly in editor.

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch 2 times, most recently from 9096d1f to e143abc Compare July 13, 2025 05:43
@RobiFerentz RobiFerentz changed the title Internal: Refactor css filter functions to make indicators work properly in editor Internal: Refactor css filter functions to make indicators work properly in editor [ED-19875] Jul 13, 2025
@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch 2 times, most recently from b4fbc3e to 3fd2b2a Compare July 13, 2025 06:00
asafdl
asafdl reviewed Jul 13, 2025
View reviewed changes
@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch 4 times, most recently from a5346a0 to 72c6d25 Compare July 13, 2025 08:25
@RobiFerentz RobiFerentz requested a review from asafdl July 13, 2025 08:25
@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch from 72c6d25 to 41d8c56 Compare July 13, 2025 09:18
@RobiFerentz RobiFerentz requested a review from asafdl July 13, 2025 09:18
asafdl
asafdl previously approved these changes Jul 13, 2025
View reviewed changes
@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch 2 times, most recently from 12c37a8 to a4561e6 Compare July 13, 2025 09:22
@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch from a4561e6 to 0c0d3e7 Compare July 13, 2025 09:33
@RobiFerentz RobiFerentz force-pushed the ED-19875_refactor_filter_functions_make_indicators_great_again branch from 0c0d3e7 to 7f2f640 Compare July 13, 2025 09:36
@RobiFerentz RobiFerentz marked this pull request as ready for review July 13, 2025 09:40
@RobiFerentz RobiFerentz merged commit d26a072 into main Jul 13, 2025
59 checks passed
@RobiFerentz RobiFerentz deleted the ED-19875_refactor_filter_functions_make_indicators_great_again branch July 13, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asafdl asafdl asafdl approved these changes

Assignees

No one assigned

Labels

30 min review 🗑️ Deleted files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RobiFerentz @asafdl