Skip to content

Internal: Show placeholders in SizeControl [ED-19244]#31800

Merged
Batsirai-muchareva merged 15 commits intoelementor:mainfrom
Batsirai-muchareva:ED-19244-show-placeholders-in-size-controls
Jul 14, 2025
Merged

Internal: Show placeholders in SizeControl [ED-19244]#31800
Batsirai-muchareva merged 15 commits intoelementor:mainfrom
Batsirai-muchareva:ED-19244-show-placeholders-in-size-controls

Conversation

@Batsirai-muchareva
Copy link
Copy Markdown
Contributor

@Batsirai-muchareva Batsirai-muchareva commented Jul 10, 2025

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

✨ PR Description

Purpose: Add placeholder support to SizeControl component to display default values when no specific value is set.
Main changes:

  • Implemented placeholder display for size input field using bound prop context data
  • Added styled unit button that changes color based on value state
  • Created useUnitPlaceholder hook to manage placeholder visibility logic
  • Added comprehensive test cases for placeholder behavior in different scenarios

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

mike-elementor
mike-elementor previously approved these changes Jul 14, 2025
@Batsirai-muchareva Batsirai-muchareva marked this pull request as ready for review July 14, 2025 18:06
Copy link
Copy Markdown
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@Batsirai-muchareva Batsirai-muchareva merged commit 51c62a1 into elementor:main Jul 14, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants