Skip to content

Internal: [V4]: Support time units in size control [ED-19762]#31718

Merged
RobiFerentz merged 2 commits intomainfrom
ED-19762_size_control_variants
Jul 13, 2025
Merged

Internal: [V4]: Support time units in size control [ED-19762]#31718
RobiFerentz merged 2 commits intomainfrom
ED-19762_size_control_variants

Conversation

@RobiFerentz
Copy link
Copy Markdown
Contributor

@RobiFerentz RobiFerentz commented Jul 6, 2025

…-

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

✨ PR Description

Purpose: Add support for time units in the size control component while refactoring unit type definitions for better organization and maintainability.

Main changes:
- Introduced new time units ('s', 'ms') alongside existing length and angle units
- Refactored unit types into specialized categories (LengthUnit, AngleUnit, TimeUnit)
- Added variant property to SizeControl to support different unit categories
- Updated size prop type validation to accommodate the new unit types

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch 2 times, most recently from 5d943cf to a6ccffa Compare July 8, 2025 04:21
@RobiFerentz RobiFerentz changed the title feat(editor-controls) support time/duration units in size control [ED-19762] Internal: [V4]: Support time units in size control [ED-19762] Jul 8, 2025
@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch 5 times, most recently from 9c146ab to 476c038 Compare July 8, 2025 05:14
mykytamurzin
mykytamurzin previously approved these changes Jul 8, 2025
@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch 3 times, most recently from 1dab3c6 to ea293c9 Compare July 10, 2025 03:22
mykytamurzin
mykytamurzin previously approved these changes Jul 10, 2025
asafdl
asafdl previously approved these changes Jul 10, 2025
@RobiFerentz RobiFerentz marked this pull request as ready for review July 10, 2025 10:49
@RobiFerentz RobiFerentz dismissed stale reviews from asafdl and mykytamurzin via 994698a July 10, 2025 11:36
@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch 2 times, most recently from 994698a to 23500ed Compare July 10, 2025 11:36
gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch from 23500ed to d0ae01e Compare July 10, 2025 11:47
gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch from 2060bfb to cb4259a Compare July 10, 2025 12:38
gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch from cb4259a to 1fb12ac Compare July 10, 2025 20:04
gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch from 1fb12ac to fc6db1a Compare July 10, 2025 20:18
gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch from fc6db1a to f100e26 Compare July 13, 2025 03:38
gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz force-pushed the ED-19762_size_control_variants branch from f100e26 to 4ed62d0 Compare July 13, 2025 03:54
gitstream-cm[bot]

This comment was marked as resolved.

@RobiFerentz RobiFerentz marked this pull request as ready for review July 13, 2025 09:26
@RobiFerentz RobiFerentz merged commit e9c8bbe into main Jul 13, 2025
47 checks passed
@RobiFerentz RobiFerentz deleted the ED-19762_size_control_variants branch July 13, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants