Feature/image carousel caption#1229
Merged
KingYes merged 12 commits intoelementor:release/1.2.0from Jan 26, 2017
Merged
Conversation
…o carousel-captions
KingYes
requested changes
Jan 26, 2017
includes/widgets/image-carousel.php
Outdated
| $slides[] = '<div class="slick-slide"><div class="slick-slide-inner">' . $image_html . '</div></div>'; | ||
| $image_caption = $this->get_image_caption( $attachment ); | ||
|
|
||
| $slides[] = '<div><figure class="slick-slide-inner">' . $image_html . '<figcaption class="elementor-image-carousel-caption">' . $image_caption . '</figcaption></figure></div>'; |
Contributor
|
Nice one - thank you for incorporating this! I'm glad it's helped everyone. When I get a free moment I may look into adding the option for absolute positioning of captions, so they can overlay the image (rather than take up space at the bottom). That is probably just a matter of writing additional CSS classes for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.