Update admin.js for fix hashtag control issue#6902
Closed
CodeExplore wants to merge 1 commit intoelementor:masterfrom
CodeExplore:master
Closed
Update admin.js for fix hashtag control issue#6902CodeExplore wants to merge 1 commit intoelementor:masterfrom CodeExplore:master
CodeExplore wants to merge 1 commit intoelementor:masterfrom
CodeExplore:master
Conversation
Contributor
|
thanks, its merged into #6903 |
Contributor
Author
|
@bainternet you're welcome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
There is an issue for hash ( # ) tag issue in admin area.
Description
Let me explain it more. For eg. Go to
Settings -> Generaland write a random hastag on the url addres. for eg:http://localhost/wp/wp-admin/options-general.php#something=hellorefresh the page and take a look console. you will see
https://github.com/pojome/elementor/blob/b7be36ae5b6fb9c90e3baa65c7adbe714c5733f0/assets/dev/js/admin/admin.js#L261
this.elements.$settingsFormPagemissing and getting error. this error making conflict with another plugin hash tags. We need a IF control like this.Test instructions
I Tested the code, it works
Quality assurance
Fixes #