Fix animation class remove on lightbox modal close#5911
Closed
sztobar wants to merge 1 commit intoelementor:masterfrom
sztobar:lightbox-close
Closed
Fix animation class remove on lightbox modal close#5911sztobar wants to merge 1 commit intoelementor:masterfrom sztobar:lightbox-close
sztobar wants to merge 1 commit intoelementor:masterfrom
sztobar:lightbox-close
Conversation
Member
|
Merge by this PR: #6063 Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
onHidecallback in lightbox module was clearinganimatedclass from incorrect widget element (widgetContentrather thanmessage). It also wasn't removingmodalOptions.entranceAnimationclass from settings.widthwhich was equal to 0 on every but first modal opening. Normally - animation is added after 10ms timeout which enables to get properwidthof the image. Because animation is not removed correctly, every next modal showing has animation class already there.Quality assurance