a11y: Video widget accessibility#3270
Merged
KingYes merged 2 commits intoelementor:release/2.0.0from Jan 22, 2018
Merged
Conversation
|
@ramiy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The video widget need some accessibility love!
Name - The iframe should have an accessibility name (https://fae.disability.illinois.edu/rulesets/FRAME_2/), either
titleoraria-labeltags.Action - The play icon should have some text saying "Play video" or some thing like that. Currently, regular visitors see the play button and understand that clicking the icon actives the video, but blind people don't see the icon. We need to add an assistive text for them.
Markup - The play icon wrapper is a
<div>, it should be a<button>. The second approach is to addrole="button"to the<div>tag.