Video Widget - Play Icon: Replace the select control with a switcher control#3262
Merged
KingYes merged 1 commit intoelementor:release/2.0.0from Jan 22, 2018
Merged
Conversation
Contributor
Author
|
I can also update the text to Show / Hide just like text in the image-overlay control and some other controls in the video options section. |
Contributor
Author
|
Also, the commit is backwards compatible as the <?php if ( 'yes' === $settings['show_play_icon'] ) : ?>
<div class="elementor-custom-embed-play">
<i class="eicon-play" aria-hidden="true"></i>
</div>
<?php endif; ?>This is why the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3241
Current
New