Fixes Image Box heading to have a working link even without an image#2854
Merged
KingYes merged 1 commit intoelementor:release/1.9.4from Feb 7, 2018
Merged
Fixes Image Box heading to have a working link even without an image#2854KingYes merged 1 commit intoelementor:release/1.9.4from
KingYes merged 1 commit intoelementor:release/1.9.4from
Conversation
Member
|
It does not make sense to display links using the Image Box widget without the image itself. |
Contributor
Author
|
@KingYes I think it does make sense for Elementor widgets to function properly even without all fields filled. A fallback. If you look at my commit, it really is a simple fix for (what I think is just) coding mistake - I just moved existing code. |
Member
|
@Jaska We have further looked into this and apparently you were right. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.