Skip to content

Add excerpt field to Elementor page settings#2837

Merged
KingYes merged 2 commits intoelementor:release/1.9.0from
ramiy:page-settings-excerpt
Nov 28, 2017
Merged

Add excerpt field to Elementor page settings#2837
KingYes merged 2 commits intoelementor:release/1.9.0from
ramiy:page-settings-excerpt

Conversation

@ramiy
Copy link
Copy Markdown
Contributor

@ramiy ramiy commented Nov 27, 2017

Related: #1579 (Enhancing the "Page Setting" panel)

page-settings-excerpt

@arielk
Copy link
Copy Markdown
Member

arielk commented Nov 27, 2017

Thanks @ramiy

But you need to check if the current CPT is support excerpt parameter

@ramiy
Copy link
Copy Markdown
Contributor Author

ramiy commented Nov 27, 2017

@arielk Done.

Tested on Pages that don't support excerpts. And then add excerpt support with Page Excerpt Plugin.

@ramiy
Copy link
Copy Markdown
Contributor Author

ramiy commented Nov 28, 2017

The PR hides the excerpt field when the post type has no excerpt support. But I think that it would be better to display the excerpt field and mark it with disabled attribute (see #1571).

@KingYes
Copy link
Copy Markdown
Member

KingYes commented Nov 28, 2017

@arielk Nice catch!

Thanks @ramiy

@KingYes KingYes merged commit 650da01 into elementor:release/1.9.0 Nov 28, 2017
@ramiy ramiy deleted the page-settings-excerpt branch November 28, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants