Approval dialog design, setup dialog fixes#95
Merged
danirabbit merged 2 commits intoscreenshot-portalfrom Dec 14, 2023
Merged
Conversation
Member
Author
|
Should we gresource the screenshot app icon here? |
davidmhewitt
approved these changes
Dec 13, 2023
Member
davidmhewitt
left a comment
There was a problem hiding this comment.
Can't remember why I didn't just use Granite.MessageDialog here 😅
But this looks way better, thanks!
Probably should gresource the icon. Feel free to follow up here or in the main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approval Dialog
Setup Dialog