Merged
Conversation
tomaswarynyca
approved these changes
Sep 29, 2021
JoseExposito
approved these changes
Sep 29, 2021
Member
JoseExposito
left a comment
There was a problem hiding this comment.
Once again, it looks good to me, but my experience with systemd is limited (and traumatic :P)
I'd appreciate another review.
This was referenced Oct 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for launching gala via the new systemd support in
gnome-session. This has no effect on the current way of doing things as we're still using the--builtinflag on our session in session settings, but it prepares us for the future.I've made this an option in meson so that distributions without systemd can use the old XDG autostarts way of launching gala in the future if they wish.
This can be tested in conjunction with #1255 and elementary/session-settings#55. If you remove the
--builtinflag from/usr/share/xsessions/pantheon.desktop,gnome-sessionwill launch Pantheon using the systemd units instead of the XDG autostarts.