Install into libexecdir instead of bindir#36
Merged
ryonakano merged 2 commits intoelementary:masterfrom Jul 17, 2024
Merged
Conversation
Member
|
I think you need to explicit install_dir in the executable function: diff --git a/src/meson.build b/src/meson.build
index bb391c4..d0cc4c2 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -30,5 +30,6 @@ executable(
meson.project_name(),
files,
dependencies: dependencies,
- install : true
+ install: true,
+ install_dir: libexecdir
) |
Contributor
Author
You’re absolutely right. I must not have tested this properly. I applied your suggestion and confirmed the installed executable path is now in |
d242276 to
5a0c65e
Compare
ryonakano
approved these changes
Jul 16, 2024
Member
ryonakano
left a comment
There was a problem hiding this comment.
Confirmed the "Compress" context menu item (that only visible if Contractor is available) in the following apps are visible even after installing this branch and rebooting the system:
- Files
- Photos
- Calendar
Also confirmed the DBus service is visible in D-Spy.
Contributor
Author
|
Awesome! Thanks for taking the time to consider and test this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell (and I may well be missing something!),
contractoris only executed via the service file, and nothing really needs it to be on the systemPATH. So… what if it’s installed inlibexecdirinstead ofbindir, i.e./usr/libexecinstead of/usr/binon a typical/usr-prefix installation?