fix(electron-updater): filter draft releases in PrivateGitHubProvider.getLatestVersionInfo#9694
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 69fb61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Agent-Logs-Url: https://github.com/electron-userland/electron-builder/sessions/e06bb1e7-23f0-4690-8645-27343305543a Co-authored-by: mmaietta <5238867+mmaietta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix draft releases not filtered in getLatestVersionInfo
fix(electron-updater): filter draft releases in PrivateGitHubProvider.getLatestVersionInfo
May 2, 2026
mmaietta
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
allowPrerelease=true, the GitHub/releasesAPI returns drafts in authenticated responses ordered bycreated_at desc. A draft prerelease near the top of the list would be selected as the latest version, silently blocking published releases — a common side effect of failed publish runs that leave orphaned drafts.Changes
getLatestVersionInfo: Filter out draft releases before selecting the latest candidate. Prefers a non-draft prerelease; falls back to the first non-draft release. If only drafts exist, returnsundefined(caller throwsERR_UPDATER_CHANNEL_FILE_NOT_FOUND) rather than silently serving a draft.ReleaseInfointerface: Addeddraftandprereleaseboolean fields to reflect the actual GitHub API response shape.