Skip to content

Conversation

@anaisbetts
Copy link
Contributor

This is @dennisameling's great PR #361 but with the released Squirrel.Windows 2.0.1 binaries. :shipit:! See #354 for the details of what's new

@dennisameling
Copy link
Contributor

Can confirm this works as expected on Windows arm64 🚀 The installer itself I also created on an arm64 device thanks to the 7-Zip arm64 binaries from this PR.

Installers are created correctly:

image

The program is installed correctly as well:

image

@malept malept requested a review from a team December 2, 2020 03:12
@malept malept changed the title feat: Update to Squirrel.Windows 2.0.1 feat!: Update to Squirrel.Windows 2.0.1 Dec 2, 2020
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me but I'd like @MarshallOfSound to take a look for a second opinion.

@anaisbetts
Copy link
Contributor Author

@malept I think he had a look at the previous PR and 👍d it, this one has no changes other than the updated binaries

@tommyvct
Copy link

Now it's been for 2 weeks, still nothing?

@dennisameling
Copy link
Contributor

Hi @MarshallOfSound, we'd be super grateful if you could review this PR. It's the final blocker for GitHub Desktop on ARM64: desktop/desktop#9691. Thanks in advance! 😊

@MarshallOfSound MarshallOfSound merged commit f03161f into electron:master Feb 18, 2021
@electron-bot
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants