Skip to content

Incorrect ABI version for Electron 3/4 #54

@bendemboski

Description

@bendemboski

I'm pretty sure the wrong ABI was specified for Electron 3, and now that Electron 4 has rolled out, its ABI incorrectly matches Electron 3's, which is causing some issues with prebuilding.

Electron 3.0.0 uses electron/node v9.7.0-33-g538a5023af, which corresponds to Node 9.7.0, which has ABI version 59. But Electron 3 was, I believe erroneously, specified as ABI version 64.

Electron 4.0.0 uses electron/node 4d44266b78256449dd6ae86e419e3ec07257b569, which corresponds to Node 10.11.0, which has ABI version 64.

So now Electron 4.0.0 is correctly specified to have ABI version 64, but 3.0.0 incorrectly shows the same ABI version as 4.0.0, which is screwing up prebuild projects, because it thinks it can reuse Electron 3 binaries for Electron 4 (causing this, and maybe this).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions