feat: allow a custom out dir from forge config#2714
feat: allow a custom out dir from forge config#2714jeanbmar wants to merge 1 commit intoelectron:mainfrom
Conversation
There was a problem hiding this comment.
@jeanbmar In general, I'm fine with this change! Could we please add some test coverage for the custom outDir option here? A good place to add them would be here: https://github.com/electron-userland/electron-forge/blob/master/packages/api/core/test/fast/forge-config_spec.ts
VerteDinde
left a comment
There was a problem hiding this comment.
Moving this to "request changes" - please add tests here! 🙂
|
Hey, will do when i can find some time for it :) |
|
This issue actually started off as electron forge issue. An unhandled rejection has occurred inside Forge:
Error: The main entry point to your app was not found. Make sure "/home/magic/out/main/index.js" exists and does not get ignored by your ignore option
at Object.validateElectronApp (/home/magic/node_modules/electron-packager/src/common.js:115:13)
at async MacApp.buildApp (/home/magic/node_modules/electron-packager/src/platform.js:135:5)
at async MacApp.initialize (/home/magic/node_modules/electron-packager/src/platform.js:127:7)
at async MacApp.create (/home/magic/node_modules/electron-packager/src/mac.js:377:5)
at async Promise.all (index 0)
at async packager (/home/magic/node_modules/electron-packager/src/index.js:204:20)But maybe if that one can be fixed soon, this PR could come in handy. |
|
Is there any plan to merge this PR anytime soon? |
Yeah, someone (or @jeanbmar ) just needs to add some tests to it first it seems 😕 |
|
Oh, ok :(
|
|
Sorry I've moved on and won't implement the missing tests. On the other hand interfaces are unchanged with this PR so I don't see why additional tests would be relevant. |
|
Duplicate of #3458 |
|
Closing as #3458 has picked up the discussion on this. |
Summarize your changes:
This PR allows using a custom outDir when packaging and making an app.
A new top-level
outDiroptional string property is added to the forgeConfig object to do so.This PR aims to:
electron-winstallerSquirrel infamous issue with long paths since files can be relocated easilyRelated issues: