Add resolvesAliases option to openDialog#8617
Conversation
docs/api/dialog.md
Outdated
| untouched on Windows. For example, a button label of `Vie&w` will be | ||
| converted to `Vie_w` on Linux and `View` on macOS and can be selected | ||
| via `Alt-W` on Windows and Linux. | ||
| * `resolvesAliases` Boolean (optional) - Whether to resolve symlinks to their target path |
There was a problem hiding this comment.
This feels like an option similar to showHiddenFiles so I'm wondering if this would be a better fit as a properties option.
What do you think?
There was a problem hiding this comment.
Would make sense to put it in with the rest of those 👍
There was a problem hiding this comment.
@MarshallOfSound #8623 was merged so there are some conflicts in this pull request now, let me know if you'd like me to resolve them.
If we do move this setting to properties it will probably need to have a negated name since it will be enabled by default for backwards-compatibility.
A couple name ideas for this:
noResolveAliasesunresolvedAliases
26aee0c to
cc24346
Compare
6550fe9 to
a746651
Compare
|
Thanks for this @MarshallOfSound 🚢 |
|
Yeah, thanks @MarshallOfSound! |
|
@MarshallOfSound , can the option |
Fixes #8601
Thanks for the detailed issue report @maxbrunsfeld was wondering what was causing this in a different Electron app for a while 😆