fix: invalidate sandboxed preload code cache when source changes without changing length#51932
Merged
Conversation
…out changing length V8's CachedData source check hashes only the source length, so a preload edit that preserves byte length consumed the stale blob and ran the old bytecode. Bind cache entries to sha256 of the source: the renderer ships the hash of what it compiled, the browser stores it in the cache entry and only serves a blob whose hash matches the contents it just read. Reject cache writes for preload ids not served to the sending frame. Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Merged
3 tasks
MarshallOfSound
approved these changes
Jun 9, 2026
VerteDinde
approved these changes
Jun 9, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51930
See that PR for details.
Notes: Fixed sandboxed preload scripts running a stale cached version after the script was modified without its file size changing.