Conversation
…forms Extends Chromium's Android/ChromeOS re-register carve-out in RendererStartupHelper::OnRenderProcessLaunched() to all platforms. The CHECK it replaces fails when a RenderProcessHost is re-initialized from inside the process-death notification - for example when an app reloads a WebContents synchronously from the 'render-process-gone' event - and brings down the browser process. Adds a regression spec that crashes a renderer and reloads it synchronously from the handler. Refs: crrev.com/c/7330559, crrev.com/c/7862000, crbug.com/512916518 Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Replaces the renderer_startup_helper.cc chromium patch from the previous commit: instead of relaxing the upstream CHECK, defer the 'render-process-gone' emit by one task so app code can no longer re-enter RenderProcessHostImpl::Init() from inside the process-death observer loop. Addresses review feedback that the CHECK should stay intact. Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
6 tasks
jkleinsc
approved these changes
Jun 8, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51900
See that PR for details.
Notes: Fixed a browser process crash when calling
webContents.reload()or navigating synchronously from therender-process-goneevent; the event is now emitted after the renderer's teardown notification has completed.