fix: use Chromium's native DevTools context menu and dialog paths#51864
Merged
Conversation
Previously DevTools context menus were implemented by overriding InspectorFrontendHost.showContextMenuAtPoint in JS and popping an Electron Menu on the inspected page's BrowserWindow. Since a detached DevTools window is not an Electron window, the menu was always anchored to (and focused) the inspected page's window. Remove the JS overrides and let Blink's native DevToolsHost.showContextMenuAtPoint path run instead: menu items arrive via WebContentsDelegate::HandleContextMenu and are shown as a native menu anchored to whichever widget hosts the DevTools view, with selections routed back through ExecuteCustomContextMenuCommand / NotifyContextMenuClosed. window.confirm in DevTools now works through a JavaScriptDialogManager on InspectableWebContents. Co-authored-by: Samuel Attard <sattard@anthropic.com>
5 tasks
MarshallOfSound
approved these changes
Jun 3, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51805
See that PR for details.
Notes: Fixed the context menu in a detached DevTools window focusing the inspected page's window instead of the DevTools window.