chore: remove dialog showHiddenFiles support on Linux#51704
Merged
jkleinsc merged 2 commits intoJun 4, 2026
Conversation
erickzhao
reviewed
May 21, 2026
| When the cookie being set is identical to an existing one (same name, domain, path, and value, with no actual changes), the change cause is `inserted-no-change-overwrite`. | ||
| When the value of the cookie being set remains unchanged but some of its attributes are updated, such as the expiration attribute, the change cause will be `inserted-no-value-change-overwrite`. | ||
|
|
||
| ### Deprecated: `showHiddenFiles` in Dialogs on Linux |
Member
There was a problem hiding this comment.
I think we should keep this heading for historical purposes.
jkleinsc
requested changes
May 27, 2026
jkleinsc
left a comment
Member
There was a problem hiding this comment.
@ckerr we shouldn't remove the deprecation from the breaking changes as @erickzhao suggests.
8639a8f to
368ee26
Compare
Member
Author
|
Rebased to |
jkleinsc
approved these changes
Jun 4, 2026
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #51880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #46817.
Remove
showHiddenFilessupport from thedialogAPI on Linux.This was deprecated in b9a09ac / #46926 for 42-x-y. This PR removes it.
Checklist
npm testpassesRelease Notes
Notes: Removed
showHiddenFilessupport from thedialogAPI on Linux.