Skip to content

fix: ship IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON and allow overriding it#51604

Merged
MarshallOfSound merged 1 commit into
41-x-yfrom
backport/41-x-y/51592
May 13, 2026
Merged

fix: ship IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON and allow overriding it#51604
MarshallOfSound merged 1 commit into
41-x-yfrom
backport/41-x-y/51592

Conversation

@MarshallOfSound

Copy link
Copy Markdown
Member

Backport of #51592

See that PR for details.

Notes: Fixed a crash in the macOS Touch ID WebAuthn prompt caused by a missing string resource, and added touchID.promptReason to app.configureWebAuthn() to customize the prompt text.

…#51592)

* fix: ship IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON and allow overriding it

Pack device/fido strings into the locale .pak files so
IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON ("verify your identity on $1") is
present at runtime. Previously the resource was never repacked, so the
macOS Touch ID prompt for WebAuthn requests crashed when looking up the
missing IDS string.

Also lets apps override the prompt text via
configureWebAuthn({ touchID: { promptReason } }) using
ResourceBundle::OverrideLocaleStringResource. An optional $1 placeholder
is replaced with the relying party ID; without it the string is used
verbatim.

* build: make //device/fido/strings an unconditional electron_lib dep

gn check does not evaluate preprocessor conditionals, so it flags the
mac-only #include of fido_strings.h on Linux/Windows even though the
include is behind BUILDFLAG(IS_MAC). Depend on //device/fido/strings on
all platforms to satisfy the header check.
@MarshallOfSound MarshallOfSound added backport This is a backport PR semver/minor backwards-compatible functionality 41-x-y labels May 13, 2026
@electron-cation electron-cation Bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels May 13, 2026
@MarshallOfSound MarshallOfSound disabled auto-merge May 13, 2026 21:29
@MarshallOfSound MarshallOfSound merged commit 5e590ee into 41-x-y May 13, 2026
75 checks passed
@MarshallOfSound MarshallOfSound deleted the backport/41-x-y/51592 branch May 13, 2026 21:29
@release-clerk

release-clerk Bot commented May 13, 2026

Copy link
Copy Markdown

Release Notes Persisted

Fixed a crash in the macOS Touch ID WebAuthn prompt caused by a missing string resource, and added touchID.promptReason to app.configureWebAuthn() to customize the prompt text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

41-x-y backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants