Skip to content

docs: update Notification 'failed' support info#51559

Merged
jkleinsc merged 1 commit into
electron:mainfrom
WofWca:patch-2
May 18, 2026
Merged

docs: update Notification 'failed' support info#51559
jkleinsc merged 1 commit into
electron:mainfrom
WofWca:patch-2

Conversation

@WofWca

@WofWca WofWca commented May 8, 2026

Copy link
Copy Markdown
Contributor

Description of Change

This is a follow-up to
#47817.

According to https://www.electronjs.org/blog/electron-42-0#behavior-changed-macos-notifications-now-use-unnotification-api

If an application is not code-signed, notifications will emit a failed event on the Notification object.

Checklist

Release Notes

Notes: Updated docs about Notification 'failed' event platform support

@WofWca
docs: update Notification 'failed' support info
07e813b 
This is a follow-up to
electron#47817.

According to https://www.electronjs.org/blog/electron-42-0#behavior-changed-macos-notifications-now-use-unnotification-api
> If an application is not code-signed, notifications will emit a `failed` event on the `Notification` object.
@electron-cation electron-cation Bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels May 8, 2026
erickzhao
erickzhao approved these changes May 8, 2026
View reviewed changes

@erickzhao erickzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer Bot approved these changes May 8, 2026
View reviewed changes

@electron-docs-reviewer electron-docs-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@erickzhao erickzhao added target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. labels May 8, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label May 9, 2026
@jkleinsc jkleinsc merged commit 97b52af into electron:main May 18, 2026
52 checks passed
@release-clerk

release-clerk Bot commented May 18, 2026

Copy link
Copy Markdown

Release Notes Persisted

Updated docs about Notification 'failed' event platform support

This was referenced May 18, 2026
Merged
Merged
@trop

trop Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "42-x-y", please check out #51688

@trop

trop Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "43-x-y", please check out #51689

@trop trop Bot added in-flight/42-x-y in-flight/43-x-y merged/43-x-y PR was merged to the "43-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. and removed target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. in-flight/43-x-y in-flight/42-x-y labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@mlaurencin mlaurencin mlaurencin approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer[bot] approved these changes

+1 more reviewer

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation 📓 merged/42-x-y PR was merged to the "42-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WofWca @ckerr @jkleinsc @dsanders11 @erickzhao @mlaurencin