Skip to content

build: create a symlink to src/buildtools during sync#51440

Closed
dsanders11 wants to merge 3 commits into
mainfrom
build/symlink-buildtools
Closed

build: create a symlink to src/buildtools during sync#51440
dsanders11 wants to merge 3 commits into
mainfrom
build/symlink-buildtools

Conversation

@dsanders11

Copy link
Copy Markdown
Member

Description of Change

We use CHROMIUM_BUILDTOOLS_PATH pretty aggressively, but recent upstream changes have made it clear that they consider it "highly unsupported" so we need to switch to a better method.

@codebytere put up electron/build-tools#855, and I agree with the general approach that symlinking it is the cleanest solution we have to work with depot_tools/gclient_paths.py. However, that PR would only work for folks using build-tools, and we also need to support folks who are building without build-tools and bring their own depot_tools.

This PR puts the symlink creation in as part of the sync process, so it will always exist whether you're building with build-tools or not. I'll follow up with a PR for build-tools to detect if the symlink exists and matches CHROMIUM_BUILDTOOLS_PATH, and if so not set the environment variable, otherwise continue to set it for backwards compatibility. After enough time has passed that we're confident all supported builds are using the changes in this PR, we can rip out CHROMIUM_BUILDTOOLS_PATH from build-tools as well.

Checklist

Release Notes

Notes: none

@dsanders11 dsanders11 added semver/none target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. labels May 1, 2026
@dsanders11 dsanders11 force-pushed the build/symlink-buildtools branch from 3c471be to 8251866 Compare May 2, 2026 00:55
@dsanders11 dsanders11 force-pushed the build/symlink-buildtools branch from 0c7f3d4 to a4da6a3 Compare May 2, 2026 01:06
@github-actions github-actions Bot added the target/43-x-y PR should also be added to the "43-x-y" branch. label May 6, 2026
@dsanders11

Copy link
Copy Markdown
Member Author

Closing in favor of a fix landed upstream: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7813342

@dsanders11 dsanders11 closed this May 8, 2026
@dsanders11 dsanders11 removed target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. labels May 8, 2026
@dsanders11 dsanders11 deleted the build/symlink-buildtools branch May 8, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant