fix: always emit executableWillLaunchAtLogin from getLoginItemSettings#51416
Merged
Conversation
`Converter<LoginItemSettings>::ToV8` only set `executableWillLaunchAtLogin` inside the Windows build block, so calling `app.getLoginItemSettings()` on macOS returned an object where the property was `undefined` rather than the boolean its type implies. Move the `executable_will_launch_at_login` field out of the Windows-only section of `LoginItemSettings` (it keeps its `false` default everywhere) and unconditionally emit the property in the V8 converter. The value is still only meaningful on Windows; on other platforms it is always `false`.
deepak1556
approved these changes
May 4, 2026
jkleinsc
approved these changes
May 5, 2026
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #51507 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #51508 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #51509 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converter<LoginItemSettings>::ToV8inshell/common/gin_converters/login_item_settings_converter.cconly setexecutableWillLaunchAtLogininside the#if BUILDFLAG(IS_WIN)branch. As a result,app.getLoginItemSettings()on macOS returned an object whereexecutableWillLaunchAtLoginwasundefinedrather than the boolean its documented type implies.Fix
executable_will_launch_at_loginfield out of the Windows-only section ofLoginItemSettingsinshell/browser/browser.hso it is defined (defaultfalse) on every platform.executableWillLaunchAtLoginin the V8 converter.The value is still only meaningful on Windows (computed by
Browser::GetLoginItemSettingsinbrowser_win.cc); on other platforms it now reliably reads asfalseinstead ofundefined.Checklist
semver/majorchangeNotes: Fixed
app.getLoginItemSettings()returningundefinedforexecutableWillLaunchAtLoginon macOS; the property is now always a boolean.