Skip to content

build: drop script/run-gn-format.py#51263

Merged
codebytere merged 1 commit into
mainfrom
build/remove-script-run-gn-format-py
Apr 23, 2026
Merged

build: drop script/run-gn-format.py#51263
codebytere merged 1 commit into
mainfrom
build/remove-script-run-gn-format-py

Conversation

@dsanders11

@dsanders11 dsanders11 commented Apr 22, 2026

Copy link
Copy Markdown
Member

Description of Change

We currently have two ways of doing GN formatting, node ./script/lint.js --gn --fix is functionally equivalent to python3 script/run-gn-format.py, so drop the latter in favor of the former.

This drops another top-level python3 script, which works towards a goal I have of eliminating all of these as they don't play nice with development on Windows where ideally python3 is provided by depot_tools.

Checklist

  • I have built and tested this change

Release Notes

Notes: none

@dsanders11 dsanders11 added semver/none target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. labels Apr 22, 2026
@codebytere codebytere merged commit 05e0cd0 into main Apr 23, 2026
136 of 138 checks passed
@codebytere codebytere deleted the build/remove-script-run-gn-format-py branch April 23, 2026 07:52
@release-clerk

release-clerk Bot commented Apr 23, 2026

Copy link
Copy Markdown

No Release Notes

This was referenced Apr 23, 2026
Merged
Merged
Merged
@trop

trop Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "40-x-y", please check out #51281

@trop

trop Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "41-x-y", please check out #51282

@trop trop Bot removed the target/40-x-y PR should also be added to the "40-x-y" branch. label Apr 23, 2026
@trop

trop Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "42-x-y", please check out #51283

@trop trop Bot added in-flight/41-x-y in-flight/42-x-y merged/42-x-y PR was merged to the "42-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. and removed target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. in-flight/42-x-y in-flight/40-x-y in-flight/41-x-y labels Apr 23, 2026
@dsanders11 dsanders11 mentioned this pull request May 8, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

No one assigned

Labels

merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. semver/none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsanders11 @VerteDinde @MarshallOfSound @codebytere