fix: crash in clipboard.readImage() on malformed image data#50475
Merged
MarshallOfSound merged 1 commit intomainfrom Mar 25, 2026
Merged
fix: crash in clipboard.readImage() on malformed image data#50475MarshallOfSound merged 1 commit intomainfrom
MarshallOfSound merged 1 commit intomainfrom
Conversation
gfx::PNGCodec::Decode() returns a null SkBitmap when it fails to decode the clipboard contents as a PNG. Passing that null bitmap to gfx::Image::CreateFrom1xBitmap() triggers a crash. Return an empty gfx::Image instead, matching the existing null-check pattern in skia_util.cc.
codebytere
approved these changes
Mar 25, 2026
|
Release Notes Persisted
|
This was referenced Mar 25, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50491 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50492 |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #50493 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50494 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gfx::PNGCodec::Decode()returns a nullSkBitmapwhen it cannot decode the clipboard contents as a PNG. Passing that null bitmap togfx::Image::CreateFrom1xBitmap()triggers a crash.This PR adds a null check and returns an empty
gfx::Imageinstead, matching the existing pattern inshell/common/skia_util.cc.Notes: Fixed a crash in
clipboard.readImage()when the clipboard contains malformed image data.