fix: hex-encode Windows notification icon temp filenames#50454
Merged
VerteDinde merged 2 commits intomainfrom Mar 25, 2026
Merged
fix: hex-encode Windows notification icon temp filenames#50454VerteDinde merged 2 commits intomainfrom
VerteDinde merged 2 commits intomainfrom
Conversation
NotificationPresenterWin was using SHA1HashString(origin.spec()) directly as the basename for the temporary PNG written for toast icons. SHA1HashString returns raw digest bytes, so the generated filename could contain invalid path characters on Windows. That caused WriteFile to fail when saving notification icons, which left toast XML without the expected icon path. Hex-encode the digest before appending .png so the temporary filename is filesystem-safe while keeping deterministic naming for a given origin.
jkleinsc
approved these changes
Mar 24, 2026
deepak1556
approved these changes
Mar 24, 2026
Co-authored-by: Robo <hop2deep@gmail.com>
VerteDinde
approved these changes
Mar 25, 2026
|
Release Notes Persisted
|
This was referenced Mar 25, 2026
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50482 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50483 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #48768
Closes #50424
NotificationPresenterWinwas usingSHA1HashString(origin.spec())directly as the basename for the temporary PNG written for toast icons.SHA1HashStringreturns raw digest bytes, so the generated filename could contain invalid path characters on Windows. That causedWriteFileto fail when saving notification icons, which left toast XML without the expected icon path.Hex-encode the digest before appending .png so the temporary filename is filesystem-safe while keeping deterministic naming for a given origin.
Checklist
npm testpassesRelease Notes
Notes: Fixed a bug where Windows notification icons could fail to save because their temporary filenames contained invalid characters.