fix: fall back to default DPI when GTK returns 0 on Linux#50453
Merged
Conversation
GetDefaultPrinterDPI() creates a blank GtkPrintSettings and reads its resolution, which returns 0 for uninitialized settings. With DPI=0, SetPrintableAreaIfValid() computes a zero scale factor, producing empty page dimensions that fail PrintMsgPrintParamsIsValid(). Fall back to kDefaultPdfDpi (72) when GTK returns 0, matching the existing Windows fallback pattern when CreateDC fails.
jkleinsc
approved these changes
Mar 24, 2026
deepak1556
approved these changes
Mar 24, 2026
ckerr
approved these changes
Mar 25, 2026
|
No Release Notes |
This was referenced Mar 25, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50488 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50489 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50490 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
GetDefaultPrinterDPI()creates a blank GtkPrintSettings and reads its resolution, which returns 0 for uninitialized settings. With DPI=0,SetPrintableAreaIfValid()computes a zero scale factor, producing empty page dimensions that failPrintMsgPrintParamsIsValid().Fall back to kDefaultPdfDpi (72) when GTK returns 0, matching the existing Windows fallback pattern when CreateDC fails.
Checklist
npm testpassesRelease Notes
Notes: none.