Skip to content

fix: don't re-parse URL unnecessarily when handling dialogs#50398

Merged
jkleinsc merged 7 commits into42-x-yfrom
trop/42-x-y-bp-fix-don-t-re-parse-url-unnecessarily-when-handling-dialogs-1774013288342
Mar 20, 2026
Merged

fix: don't re-parse URL unnecessarily when handling dialogs#50398
jkleinsc merged 7 commits into42-x-yfrom
trop/42-x-y-bp-fix-don-t-re-parse-url-unnecessarily-when-handling-dialogs-1774013288342

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Mar 20, 2026

Backport of #50062

See that PR for details.

Notes: Fixed crash when handling JavaScript dialogs from windows opened with invalid or empty URLs.

trop bot and others added 7 commits March 20, 2026 13:28
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>
@trop trop bot requested a review from a team March 20, 2026 13:29
@trop trop bot added 42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 20, 2026
@jkleinsc jkleinsc merged commit 1766e22 into 42-x-y Mar 20, 2026
72 checks passed
@jkleinsc jkleinsc deleted the trop/42-x-y-bp-fix-don-t-re-parse-url-unnecessarily-when-handling-dialogs-1774013288342 branch March 20, 2026 15:32
@release-clerk
Copy link

release-clerk bot commented Mar 20, 2026

Release Notes Persisted

Fixed crash when handling JavaScript dialogs from windows opened with invalid or empty URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant