fix: prefer browser runtime over node in DevTools HostRuntime detection#50241
Merged
codebytere merged 1 commit intomainfrom Mar 16, 2026
Merged
fix: prefer browser runtime over node in DevTools HostRuntime detection#50241codebytere merged 1 commit intomainfrom
codebytere merged 1 commit intomainfrom
Conversation
Upstream DevTools' HostRuntime checks `IS_NODE` before `IS_BROWSER` when selecting the platform runtime. In Electron, `process` is available in renderer processes, so `IS_NODE` evaluates to `true` in the DevTools context. This causes DevTools to dynamically import the Node.js platform runtime, which uses `node:worker_threads`. DevTools Web Workers running under the `devtools://` protocol cannot load Node.js built-in modules, so the import fails and breaks features like the formatter worker. Fix by swapping the check order to prefer `IS_BROWSER` when both are true. This is safe because in pure Node.js environments (the only case where the node runtime is needed), `window` and `self` are both undefined, so `IS_BROWSER` is always `false` regardless of check order.
deepak1556
approved these changes
Mar 13, 2026
Member
There was a problem hiding this comment.
Stale comment, but was wondering if this would regression loading node entrypoints like devtools://devtools/bundled/js_app.html?v8only=true and realized this is more about the process hosting the devtools which shouldn't affect the app entrypoints.
LGTM
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50274 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50275 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #50220
Upstream DevTools' HostRuntime checks
IS_NODEbeforeIS_BROWSERwhen selecting the platform runtime. In Electron,processis available in renderer processes, soIS_NODEevaluates totruein the DevTools context. This causes DevTools to dynamically import the Node.js platform runtime, which usesnode:worker_threads. DevTools Web Workers running under thedevtools://protocol cannot load Node.js built-in modules, so the import fails and breaks features like the formatter worker.Fix by swapping the check order to prefer
IS_BROWSERwhen both are true. This is safe because in pure Node.js environments (the only case where the node runtime is needed),windowandselfare both undefined, soIS_BROWSERis alwaysfalseregardless of check order.Upstreamed at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7665878
Checklist
npm testpassesRelease Notes
Notes: Fix an issue where some DevTools functionality didn't work as expected.