Skip to content

fix: add ASAR support to additional copy methods#50226

Merged
codebytere merged 2 commits intoelectron:mainfrom
nmggithub:asar-copy-support
Mar 16, 2026
Merged

fix: add ASAR support to additional copy methods#50226
codebytere merged 2 commits intoelectron:mainfrom
nmggithub:asar-copy-support

Conversation

@nmggithub
Copy link
Copy Markdown
Contributor

@nmggithub nmggithub commented Mar 12, 2026

Description of Change

This is a follow-up on PR #49013, which appears to have gone stale. Filing this on request of @nikwen.

Checklist

Release Notes

Notes: Added additional ASAR support to additional fs copy methods.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 12, 2026
nikwen
nikwen approved these changes Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nikwen nikwen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Implementation approved on the basis that @codebytere reviewed the code in #49013.)

@nikwen nikwen added target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. semver/patch backwards-compatible bug fixes labels Mar 12, 2026
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 13, 2026
@github-actions github-actions bot added the target/42-x-y PR should also be added to the "42-x-y" branch. label Mar 13, 2026
@codebytere codebytere merged commit a561dd9 into electron:main Mar 16, 2026
160 of 164 checks passed
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 16, 2026

Release Notes Persisted

Added additional ASAR support to additional fs copy methods.

This was referenced Mar 16, 2026
Merged
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 16, 2026

I have automatically backported this PR to "39-x-y", please check out #50284

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 16, 2026

I have automatically backported this PR to "42-x-y", please check out #50285

@trop trop bot removed the target/39-x-y PR should also be added to the "39-x-y" branch. label Mar 16, 2026
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 16, 2026

I have automatically backported this PR to "41-x-y", please check out #50286

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 16, 2026

I have automatically backported this PR to "40-x-y", please check out #50287

@trop trop bot added in-flight/42-x-y in-flight/41-x-y in-flight/40-x-y and removed target/42-x-y PR should also be added to the "42-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. in-flight/42-x-y labels Mar 16, 2026
@trop trop bot added merged/42-x-y PR was merged to the "42-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. and removed in-flight/39-x-y in-flight/41-x-y in-flight/40-x-y labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

@nikwen nikwen nikwen approved these changes

Assignees

No one assigned

Labels

merged/39-x-y PR was merged to the "39-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmggithub @codebytere @nikwen