fix: validate response header names and values before AddHeader#50123
Merged
MarshallOfSound merged 1 commit intomainfrom Mar 8, 2026
Merged
fix: validate response header names and values before AddHeader#50123MarshallOfSound merged 1 commit intomainfrom
MarshallOfSound merged 1 commit intomainfrom
Conversation
Matches the existing validation applied to request headers in electron_api_url_loader.cc.
codebytere
approved these changes
Mar 8, 2026
|
Release Notes Persisted
|
This was referenced Mar 8, 2026
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #50129 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #50130 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50131 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
net::HttpUtil::IsValidHeaderName/IsValidHeaderValuechecks before callingHttpResponseHeaders::AddHeaderin:ToResponseHead(custom protocol handler response headers) — invalid headers are droppedConverter<HttpResponseHeaders*>::FromV8(webRequest.onHeadersReceived) — conversion fails on invalid inputThis matches the existing validation already applied to request headers in
electron_api_url_loader.cc.Notes: Fixed an issue where invalid characters in custom protocol or webRequest response header values were not rejected.