Skip to content

feat: show toast dismissal reason on Windows#49913

Merged
jkleinsc merged 2 commits intomainfrom
toast-dismissal-reason
Mar 2, 2026
Merged

feat: show toast dismissal reason on Windows#49913
jkleinsc merged 2 commits intomainfrom
toast-dismissal-reason

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Feb 23, 2026

Description of Change

Part of work to improve the notification experience on Windows. It's potentially useful to developers to know the reason a notification was closed.

Checklist

Release Notes

Notes: Added a reason property to the Notification 'closed' event on Windows to allow developers to know the reason the Notification was dismissed.

@codebytere codebytere added semver/minor backwards-compatible functionality target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Feb 23, 2026
ckerr
ckerr approved these changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

API LGTM

Comment thread shell/browser/api/electron_api_notification.cc
void Notification::NotificationClosed(const std::string& reason) {
if (reason.empty()) {
Emit("close");
} else {
Copy link
Copy Markdown
Member

@ckerr ckerr Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe return here instead of if-else

dsanders11
dsanders11 reviewed Feb 23, 2026
View reviewed changes
Comment thread docs/api/notification.md Outdated
@codebytere @dsanders11
Update docs/api/notification.md
0e824e1 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
jkleinsc
jkleinsc reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit 4c3565f into main Mar 2, 2026
111 of 112 checks passed
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Mar 2, 2026

Release Notes Persisted

Added a reason property to the Notification 'closed' event on Windows to allow developers to know the reason the Notification was dismissed.

@jkleinsc jkleinsc deleted the toast-dismissal-reason branch March 2, 2026 16:38
This was referenced Mar 2, 2026
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Mar 2, 2026

I have automatically backported this PR to "41-x-y", please check out #50029

@trop trop Bot added the in-flight/41-x-y label Mar 2, 2026
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Mar 2, 2026

I have automatically backported this PR to "40-x-y", please check out #50030

@trop trop Bot added in-flight/40-x-y merged/40-x-y PR was merged to the "40-x-y" branch. and removed target/41-x-y PR should also be added to the "41-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. in-flight/40-x-y labels Mar 2, 2026
@trop trop Bot added merged/41-x-y PR was merged to the "41-x-y" branch. and removed in-flight/41-x-y labels Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

No one assigned

Labels

api-review/approved ✅ merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codebytere @ckerr @jkleinsc @VerteDinde @dsanders11