feat: add accessibilityDisplayShouldDifferentiateWithoutColor on macOS#49912
Merged
jkleinsc merged 1 commit intoelectron:mainfrom Mar 20, 2026
Merged
Conversation
Member
|
@robb can you please sign your commit? |
b0719da to
7ec4bd3
Compare
Contributor
Author
|
@codebytere There you go |
jkleinsc
requested changes
Feb 26, 2026
Member
jkleinsc
left a comment
There was a problem hiding this comment.
I think it makes more sense to put this in nativeTheme but I'll defer to @codebytere if there is a reason this belongs in systemPreferences vs nativeTheme.
@jkleinsc you're correct - this should be moved to nativeTheme.
Contributor
Author
|
Cool, I'll move it over when I'm back in the office on Monday. |
7ec4bd3 to
0b2b5b9
Compare
Contributor
Author
|
|
jkleinsc
approved these changes
Mar 3, 2026
Contributor
Author
|
Let me know if there's something on my end to get this unstuck but fwict it's a CI-side issue? |
Member
|
@robb could you please rebase? sorry for the delay here! |
9e56bec to
5f325d3
Compare
Contributor
Author
|
@codebytere No worries, hope this worked. |
Adds nativeTheme.shouldDifferentiateWithoutColor on macOS that maps to NSWorkspace.accessibilityDisplayShouldDifferentiateWithoutColor. If true, the user has indicated that they prefer UI that differentiates items with something other than color alone. This is useful for users with color vision deficiency.
5f325d3 to
b390209
Compare
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
This was referenced Mar 20, 2026
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50408 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds
nativeTheme.shouldDifferentiateWithoutColoron macOS that maps to theaccessibilityDisplayShouldDifferentiateWithoutColorproperty onNSWorkspace. Iftrue, the user has indicated that they prefer UI that differentiates items with something other than color alone. This is useful for users with color vision deficiency.For example, an app like Linear might use this to automatically show diffs in a way that that deemphasizes usage of red and green to indicate removals and additions.
A somewhat equivalent media query has been discussed, fwiw: w3c/csswg-drafts#10335
Checklist
npm testpasseschangedor addedRelease Notes
Notes: Added nativeTheme.shouldDifferentiateWithoutColor on macOS