fix: InspectorFrontendHost override in embedded windows#49794
Merged
codebytere merged 1 commit intomainfrom Mar 9, 2026
Merged
fix: InspectorFrontendHost override in embedded windows#49794codebytere merged 1 commit intomainfrom
InspectorFrontendHost override in embedded windows#49794codebytere merged 1 commit intomainfrom
Conversation
fc58831 to
8bf18c6
Compare
8bf18c6 to
90f1c37
Compare
ckerr
reviewed
Feb 19, 2026
ckerr
reviewed
Feb 20, 2026
| TraceKeyPath(global, key_path, allow_silent_failure); | ||
| if (!maybe_target_object.has_value()) | ||
| return; | ||
| gin_helper::Dictionary target_object = std::move(maybe_target_object); |
Member
There was a problem hiding this comment.
Oof, sorry for the noise. TIL gin_helper::Dictionary isn't movable.
Either of these would be fine:
- Go back to making a copy
- Avoid the copy by using a reference
auto& target_object = *maybe_target_object;
8ad2e87 to
90f1c37
Compare
778c56d to
1dfc9d2
Compare
1dfc9d2 to
cf9358a
Compare
jkleinsc
approved these changes
Mar 6, 2026
|
Release Notes Persisted
|
This was referenced Mar 9, 2026
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #50136 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50137 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #49753
Adds a path to
_overrideGlobalValueFromIsolatedWorldthat allows for silent failure when a given property doesn't exist on an object without hard CHECKing.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Chrome Devtools menus may not appear in certain embedded windows.