fix: correctly track BaseWindow::IsActive() on MacOS#49460
Merged
jkleinsc merged 1 commit intoelectron:mainfrom Mar 18, 2026
Merged
fix: correctly track BaseWindow::IsActive() on MacOS#49460jkleinsc merged 1 commit intoelectron:mainfrom
jkleinsc merged 1 commit intoelectron:mainfrom
Conversation
5 tasks
Member
|
LGTM, can you add a test. Thanks! |
ckerr
reviewed
Jan 22, 2026
Member
ckerr
left a comment
There was a problem hiding this comment.
Code looks fine. Agree with @deepak1556 about adding a test if possible
Member
|
@kycutler do you have time to add a test to this PR? |
ckerr
approved these changes
Feb 24, 2026
Member
|
I'd prefer a test for this but wouldn't block the PR on it |
jkleinsc
approved these changes
Mar 18, 2026
|
Release Notes Persisted
|
This was referenced Mar 18, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50337 |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #50338 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50339 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Extend #24286 to BaseWindow
Checklist
Release Notes
Notes: Fixed improper focus tracking in BaseWindow on MacOS