Respect HTTP(S) proxy env variable for Yarn#49361
Closed
panther7 wants to merge 1 commit intoelectron:mainfrom
Closed
Respect HTTP(S) proxy env variable for Yarn#49361panther7 wants to merge 1 commit intoelectron:mainfrom
panther7 wants to merge 1 commit intoelectron:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Hello @panther7! It looks like this pull request touches one of our dependency or CI files, and per our contribution policy we do not accept these types of changes in PRs.
3 tasks
Contributor
Author
|
Why was closed? @nikwen said: "Create PR..." #49171 (comment) |
Member
|
@panther7 #49361 (review). We unfortunately do not allow non-maintainers to modify certain files. I apologize that you we informed otherwise. I'll submit a PR crediting you with the fix. |
3 tasks
Member
|
PR is up here: #50322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
#49171
Release Notes
Notes: none