feat: support WebSocket authentication handling #49065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ckerr
previously requested changes
Nov 25, 2025
Member
ckerr
left a comment
There was a problem hiding this comment.
FTBFS
2025-11-25T05:25:54.0585697Z In file included from ../../electron/shell/browser/net/proxying_websocket.cc:5:
2025-11-25T05:25:54.0614346Z ##[error]../../electron/shell/browser/net/proxying_websocket.h:107:31: error: use of undeclared identifier 'api'; did you mean 'extensions::api'?
2025-11-25T05:25:54.0615226Z 107 | void OnAuthRequiredComplete(api::WebRequest::AuthRequiredResponse rv);
2025-11-25T05:25:54.0615657Z | ^~~
2025-11-25T05:25:54.0615992Z | extensions::api
2025-11-25T05:25:54.0616529Z gen/extensions/common/api/declarative_net_request.h:28:11: note: 'extensions::api' declared here
2025-11-25T05:25:54.0616997Z 28 | namespace api {
2025-11-25T05:25:54.0617241Z | ^
2025-11-25T05:25:54.0617613Z In file included from ../../electron/shell/browser/net/proxying_websocket.cc:5:
2025-11-25T05:25:54.0619309Z ##[error]../../electron/shell/browser/net/proxying_websocket.h:107:31: error: no member named 'WebRequest' in namespace 'extensions::api'; did you mean 'WebRequestAPI'?
2025-11-25T05:25:54.0620099Z 107 | void OnAuthRequiredComplete(api::WebRequest::AuthRequiredResponse rv);
2025-11-25T05:25:54.0620524Z | ^~~~~~~~~~~~~~~
2025-11-25T05:25:54.0620843Z | WebRequestAPI
2025-11-25T05:25:54.0621385Z ../../electron/shell/browser/net/web_request_api_interface.h:21:7: note: 'WebRequestAPI' declared here
2025-11-25T05:25:54.0621857Z 21 | class WebRequestAPI {
2025-11-25T05:25:54.0622107Z | ^
2025-11-25T05:25:54.0622467Z In file included from ../../electron/shell/browser/net/proxying_websocket.cc:5:
2025-11-25T05:25:54.0623467Z ##[error]../../electron/shell/browser/net/proxying_websocket.h:107:48: error: no type named 'AuthRequiredResponse' in 'electron::WebRequestAPI'
2025-11-25T05:25:54.0624338Z 107 | void OnAuthRequiredComplete(api::WebRequest::AuthRequiredResponse rv);
2025-11-25T05:25:54.0624765Z | ~~~~~~~~~~~~~~~~~^
2025-11-25T05:25:54.0625649Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:376:5: error: use of undeclared identifier 'api'; did you mean 'extensions::api'?
2025-11-25T05:25:54.0626282Z 376 | api::WebRequest::AuthRequiredResponse rv) {
2025-11-25T05:25:54.0626647Z | ^~~
2025-11-25T05:25:54.0627002Z | extensions::api
2025-11-25T05:25:54.0627506Z gen/extensions/common/api/declarative_net_request.h:28:11: note: 'extensions::api' declared here
2025-11-25T05:25:54.0627980Z 28 | namespace api {
2025-11-25T05:25:54.0628525Z | ^
2025-11-25T05:25:54.0629484Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:376:5: error: no member named 'WebRequest' in namespace 'extensions::api'; did you mean 'WebRequestAPI'?
2025-11-25T05:25:54.0630169Z 376 | api::WebRequest::AuthRequiredResponse rv) {
2025-11-25T05:25:54.0630478Z | ^~~~~~~~~~~~~~~
2025-11-25T05:25:54.0630721Z | WebRequestAPI
2025-11-25T05:25:54.0631202Z ../../electron/shell/browser/net/web_request_api_interface.h:21:7: note: 'WebRequestAPI' declared here
2025-11-25T05:25:54.0631672Z 21 | class WebRequestAPI {
2025-11-25T05:25:54.0631916Z | ^
2025-11-25T05:25:54.0632701Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:376:22: error: no type named 'AuthRequiredResponse' in 'electron::WebRequestAPI'
2025-11-25T05:25:54.0633316Z 376 | api::WebRequest::AuthRequiredResponse rv) {
2025-11-25T05:25:54.0633625Z | ~~~~~~~~~~~~~~~~~^
2025-11-25T05:25:54.0634425Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:380:10: error: use of undeclared identifier 'api'; did you mean 'extensions::api'?
2025-11-25T05:25:54.0635051Z 380 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0635362Z | ^~~
2025-11-25T05:25:54.0635606Z | extensions::api
2025-11-25T05:25:54.0636100Z gen/extensions/common/api/declarative_net_request.h:28:11: note: 'extensions::api' declared here
2025-11-25T05:25:54.0636552Z 28 | namespace api {
2025-11-25T05:25:54.0636781Z | ^
2025-11-25T05:25:54.0637684Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:380:10: error: no member named 'WebRequest' in namespace 'extensions::api'; did you mean 'WebRequestAPI'?
2025-11-25T05:25:54.0638374Z 380 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0638696Z | ^~~~~~~~~~~~~~~
2025-11-25T05:25:54.0638957Z | WebRequestAPI
2025-11-25T05:25:54.0639449Z ../../electron/shell/browser/net/web_request_api_interface.h:21:7: note: 'WebRequestAPI' declared here
2025-11-25T05:25:54.0639903Z 21 | class WebRequestAPI {
2025-11-25T05:25:54.0640157Z | ^
2025-11-25T05:25:54.0640933Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:380:27: error: no member named 'AuthRequiredResponse' in 'electron::WebRequestAPI'
2025-11-25T05:25:54.0641563Z 380 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0641881Z | ~~~~~~~~~~~~~~~~~^
2025-11-25T05:25:54.0642693Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:382:10: error: use of undeclared identifier 'api'; did you mean 'extensions::api'?
2025-11-25T05:25:54.0643314Z 382 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0643629Z | ^~~
2025-11-25T05:25:54.0643873Z | extensions::api
2025-11-25T05:25:54.0644361Z gen/extensions/common/api/declarative_net_request.h:28:11: note: 'extensions::api' declared here
2025-11-25T05:25:54.0644815Z 28 | namespace api {
2025-11-25T05:25:54.0645045Z | ^
2025-11-25T05:25:54.0645949Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:382:10: error: no member named 'WebRequest' in namespace 'extensions::api'; did you mean 'WebRequestAPI'?
2025-11-25T05:25:54.0646735Z 382 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0647057Z | ^~~~~~~~~~~~~~~
2025-11-25T05:25:54.0647326Z | WebRequestAPI
2025-11-25T05:25:54.0647812Z ../../electron/shell/browser/net/web_request_api_interface.h:21:7: note: 'WebRequestAPI' declared here
2025-11-25T05:25:54.0648273Z 21 | class WebRequestAPI {
2025-11-25T05:25:54.0648524Z | ^
2025-11-25T05:25:54.0649398Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:382:27: error: no member named 'AuthRequiredResponse' in 'electron::WebRequestAPI'
2025-11-25T05:25:54.0650082Z 382 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0650402Z | ~~~~~~~~~~~~~~~~~^
2025-11-25T05:25:54.0651203Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:387:10: error: use of undeclared identifier 'api'; did you mean 'extensions::api'?
2025-11-25T05:25:54.0651916Z 387 | case api::WebRequest::AuthRequiredResponse::AUTH_REQUIRED_RESPONSE_SET_AUTH:
2025-11-25T05:25:54.0652306Z | ^~~
2025-11-25T05:25:54.0652546Z | extensions::api
2025-11-25T05:25:54.0653039Z gen/extensions/common/api/declarative_net_request.h:28:11: note: 'extensions::api' declared here
2025-11-25T05:25:54.0653491Z 28 | namespace api {
2025-11-25T05:25:54.0653723Z | ^
2025-11-25T05:25:54.0654621Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:387:10: error: no member named 'WebRequest' in namespace 'extensions::api'; did you mean 'WebRequestAPI'?
2025-11-25T05:25:54.0655393Z 387 | case api::WebRequest::AuthRequiredResponse::AUTH_REQUIRED_RESPONSE_SET_AUTH:
2025-11-25T05:25:54.0655799Z | ^~~~~~~~~~~~~~~
2025-11-25T05:25:54.0656062Z | WebRequestAPI
2025-11-25T05:25:54.0656544Z ../../electron/shell/browser/net/web_request_api_interface.h:21:7: note: 'WebRequestAPI' declared here
2025-11-25T05:25:54.0657007Z 21 | class WebRequestAPI {
2025-11-25T05:25:54.0657252Z | ^
2025-11-25T05:25:54.0658038Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:387:27: error: no member named 'AuthRequiredResponse' in 'electron::WebRequestAPI'
2025-11-25T05:25:54.0658749Z 387 | case api::WebRequest::AuthRequiredResponse::AUTH_REQUIRED_RESPONSE_SET_AUTH:
2025-11-25T05:25:54.0659147Z | ~~~~~~~~~~~~~~~~~^
2025-11-25T05:25:54.0659955Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:390:10: error: use of undeclared identifier 'api'; did you mean 'extensions::api'?
2025-11-25T05:25:54.0660589Z 390 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0660900Z | ^~~
2025-11-25T05:25:54.0661141Z | extensions::api
2025-11-25T05:25:54.0661623Z gen/extensions/common/api/declarative_net_request.h:28:11: note: 'extensions::api' declared here
2025-11-25T05:25:54.0662075Z 28 | namespace api {
2025-11-25T05:25:54.0662303Z | ^
2025-11-25T05:25:54.0663183Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:390:10: error: no member named 'WebRequest' in namespace 'extensions::api'; did you mean 'WebRequestAPI'?
2025-11-25T05:25:54.0663863Z 390 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0664182Z | ^~~~~~~~~~~~~~~
2025-11-25T05:25:54.0664439Z | WebRequestAPI
2025-11-25T05:25:54.0664919Z ../../electron/shell/browser/net/web_request_api_interface.h:21:7: note: 'WebRequestAPI' declared here
2025-11-25T05:25:54.0665380Z 21 | class WebRequestAPI {
2025-11-25T05:25:54.0665622Z | ^
2025-11-25T05:25:54.0666391Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:390:27: error: no member named 'AuthRequiredResponse' in 'electron::WebRequestAPI'
2025-11-25T05:25:54.0667011Z 390 | case api::WebRequest::AuthRequiredResponse::
2025-11-25T05:25:54.0667323Z | ~~~~~~~~~~~~~~~~~^
2025-11-25T05:25:54.0668326Z ##[error]../../electron/shell/browser/net/proxying_websocket.cc:408:18: error: use of undeclared identifier 'web_request_'
2025-11-25T05:25:54.0668891Z 408 | auto auth_rv = web_request_->OnAuthRequired(
2025-11-25T05:25:54.0669218Z | ^~~~~~~~~~~~
2025-11-25T05:25:54.0669585Z fatal error: too many errors emitted, stopping now [-ferror-limit=]
2025-11-25T05:25:54.0669942Z 20 errors generated.
3a4415e to
4bea90d
Compare
Member
|
This is hitting an unrelated CI failure:
I'm going to rebase this to pick up 245e70a |
jkleinsc
approved these changes
Jan 13, 2026
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48512.
See that PR for details.
Notes: Added support for WebSocket authentication through the
loginevent onwebContents.