Skip to content

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Oct 28, 2025

Backport of #46386

See that PR for details.

Notes: Automatically focus DevTools when element is inspected or breakpoint is triggered.

`bringToFront` DevTools message is sent when breakpoint is triggered
or inspect is called and Chromium upon this message activates DevTools
via `DevToolsUIBindings::Delegate::ActivateWindow`:
```
void DevToolsWindow::ActivateWindow() {
  if (life_stage_ != kLoadCompleted)
    return;
\#if BUILDFLAG(IS_ANDROID)
  NOTIMPLEMENTED();
\#else
  if (is_docked_ && GetInspectedBrowserWindow())
    main_web_contents_->Focus();
  else if (!is_docked_ && browser_ && !browser_->window()->IsActive())
    browser_->window()->Activate();
\#endif
}
```
which implements: `DevToolsUIBindings::Delegate::ActivateWindow`.

Electron also implements this interface in:
`electron::InspectableWebContents`. However it was only setting
a zoom level, therefore this commit extends it with activation
of the DevTools.

Only supported for DevTools manged by `electron::InspectableWebContents`.

Closes: #37388

Co-authored-by: Michał Pichliński <michal.pichlinski@here.io>
@trop trop bot requested a review from a team October 28, 2025 12:46
@trop trop bot added 38-x-y backport This is a backport PR backport/requested 🗳 semver/patch backwards-compatible bug fixes labels Oct 28, 2025
@jkleinsc
Copy link
Member

Releases WG has approved this backport.

@jkleinsc jkleinsc merged commit 074cedd into 38-x-y Nov 10, 2025
112 of 113 checks passed
@jkleinsc jkleinsc deleted the trop/38-x-y-bp-feat-focus-devtools-when-breakpoint-is-triggered-1761655600714 branch November 10, 2025 21:41
@release-clerk
Copy link

release-clerk bot commented Nov 10, 2025

Release Notes Persisted

Automatically focus DevTools when element is inspected or breakpoint is triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

38-x-y backport/approved ✅ backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants