Skip to content

fix: remove unneeded handlescope from JS callbacks #48344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepak1556 merged 1 commit into from
Sep 17, 2025
Merged

fix: remove unneeded handlescope from JS callbacks #48344

deepak1556 merged 1 commit into from
Sep 17, 2025

Conversation

@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Sep 17, 2025 •
edited
Loading

Backport of #48318

See that PR for details.

Notes: fix crash when accessing webContents.session

@deepak1556
fix: remove unneeded handlescope from JS callbacks (#48318)
408b7c1 
fix: remove handlescope from JS callbacks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 17, 2025
@trop trop bot mentioned this pull request Sep 17, 2025
Merged
5 tasks
@trop trop bot requested a review from a team September 17, 2025 16:29
@trop trop bot added 39-x-y backport This is a backport PR semver/minor backwards-compatible functionality labels Sep 17, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 17, 2025
@trop trop bot mentioned this pull request Sep 17, 2025
Merged
@deepak1556
Copy link
Member Author

deepak1556 commented Sep 17, 2025

Failing test is unrelated, merging

@deepak1556 deepak1556 merged commit 40fb762 into 39-x-y Sep 17, 2025
109 of 113 checks passed
@deepak1556 deepak1556 deleted the robo/backport_48318_39_x_y branch September 17, 2025 23:47
@release-clerk
Copy link

release-clerk bot commented Sep 17, 2025

Release Notes Persisted

fix crash when accessing webContents.session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

No one assigned

Labels

39-x-y backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deepak1556 @ckerr @dsanders11