Skip to content

fix: fix and enable accessibilitySupportEnabled tests (36-x-y)#47196

Merged
jkleinsc merged 1 commit into36-x-yfrom
fix/enable-accessibilitySupportEnabled-tests--36-x-y
May 23, 2025
Merged

fix: fix and enable accessibilitySupportEnabled tests (36-x-y)#47196
jkleinsc merged 1 commit into36-x-yfrom
fix/enable-accessibilitySupportEnabled-tests--36-x-y

Conversation

@ckerr
Copy link
Copy Markdown
Member

@ckerr ckerr commented May 21, 2025

Manual backport of #46825 to 36-x-y. See that PR for details.

Notes: none.

@ckerr ckerr added backport This is a backport PR 36-x-y labels May 21, 2025
@trop trop Bot requested a review from a team May 21, 2025 17:27
@trop trop Bot added the semver/patch backwards-compatible bug fixes label May 21, 2025
@dsanders11 dsanders11 changed the title Fix/enable accessibility support enabled tests 36 x y fix: fix and enable accessibilitySupportEnabled tests May 21, 2025
@ckerr ckerr changed the title fix: fix and enable accessibilitySupportEnabled tests fix: fix and enable accessibilitySupportEnabled tests (36-x-y) May 21, 2025
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a stray change made its way into this PR.

Comment thread spec/api-browser-window-spec.ts Outdated
* test: enable accessibilitySupportEnabled tests

* test: check both getters after calling each setter

*  fix: do not assume the default initial value of accessibilitySupportEnabled

* chore: remove redundant test case

* chore: disable accessibilitySupportEnabled tests on Linux
@ckerr ckerr force-pushed the fix/enable-accessibilitySupportEnabled-tests--36-x-y branch from ae41cc0 to cd1c7fc Compare May 22, 2025 04:59
@codebytere codebytere requested a review from jkleinsc May 22, 2025 14:12
@jkleinsc jkleinsc merged commit 1c132a3 into 36-x-y May 23, 2025
54 checks passed
@jkleinsc jkleinsc deleted the fix/enable-accessibilitySupportEnabled-tests--36-x-y branch May 23, 2025 15:15
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented May 23, 2025

No Release Notes

@danielweck
Copy link
Copy Markdown

Regression in v37:

#48039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

36-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants