fix: enable `mocha/no-nested-tests` in eslint by ckerr · Pull Request #46807 · electron/electron

ckerr · 2025-04-26T00:59:17Z

Description of Change

Enable the mocha/no-nested-tests warning and fix the pre-existing instances. This fixes a problem that caused 57 tests to not be run.

Fixes #46806.

Notes: none.

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: none.

nikwen

Good catch!

nikwen · 2025-04-26T03:23:45Z

Looks like some of the re-enabled tests are failing.

ckerr · 2025-04-26T16:36:15Z

Yep, not great.

On the Windows size, windows-x64, windows-x86, and windows-arm64 all have the same three test failures:

2025-04-26T02:23:16.8606168Z not ok 221 BrowserWindow module sizing BrowserWindow.getNormalBounds() Fullscreen state with properties does not go fullscreen if roundedCorners are enabled
2025-04-26T02:23:16.8607043Z   expected true to be false
2025-04-26T02:23:16.8607677Z   AssertionError: expected true to be false
2025-04-26T02:23:16.8608235Z       at Context.<anonymous> (electron\spec\api-browser-window-spec.ts:2113:45)
2025-04-26T02:23:16.8608753Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T02:23:48.0526349Z not ok 437 BrowserWindow module window states (excluding Linux) visibleOnAllWorkspaces state with properties can be changed
2025-04-26T02:23:48.0528216Z   expected false to be true
2025-04-26T02:23:48.0528624Z   AssertionError: expected false to be true
2025-04-26T02:23:48.0529218Z       at Context.<anonymous> (electron\spec\api-browser-window-spec.ts:5456:54)
2025-04-26T02:23:48.0530687Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T02:23:48.1109508Z not ok 438 BrowserWindow module window states (excluding Linux) visibleOnAllWorkspaces state with functions can be changed
2025-04-26T02:23:48.1112440Z   expected false to be true
2025-04-26T02:23:48.1113848Z   AssertionError: expected false to be true
2025-04-26T02:23:48.1114879Z       at Context.<anonymous> (electron\spec\api-browser-window-spec.ts:5465:58)
2025-04-26T02:23:48.1115796Z       at processImmediate (node:internal/timers:491:21)

ckerr · 2025-04-26T16:40:38Z

not ok 437 BrowserWindow module window states (excluding Linux) visibleOnAllWorkspaces state with properties can be changed

not ok 438 BrowserWindow module window states (excluding Linux) visibleOnAllWorkspaces state with functions can be changed

These two failures are to be expected: win.visibleOnAllWorkspaces is not supported on Windows, so I'll disable them there. In addition, this test probably should be enabled on Linux since the feature is supported on that platform? 😵

ckerr · 2025-04-26T17:05:55Z

Lots of "new" failures in macOS:

2025-04-26T01:52:44.6552870Z not ok 243 BrowserWindow module autoHideMenuBar state for properties can be set with autoHideMenuBar constructor option
2025-04-26T01:52:44.6643840Z   autoHideMenuBar: expected false to be true
2025-04-26T01:52:44.6716210Z   AssertionError: autoHideMenuBar: expected false to be true
2025-04-26T01:52:44.6718060Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:2370:45)
2025-04-26T01:52:44.6747980Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:52:44.7865730Z not ok 244 BrowserWindow module autoHideMenuBar state for properties can be changed
2025-04-26T01:52:44.7891580Z   autoHideMenuBar: expected false to be true
2025-04-26T01:52:44.7925710Z   AssertionError: autoHideMenuBar: expected false to be true
2025-04-26T01:52:44.7959440Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:2377:45)
2025-04-26T01:52:44.7996940Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:52:45.0030270Z not ok 245 BrowserWindow module autoHideMenuBar state for functions can be set with autoHideMenuBar constructor option
2025-04-26T01:52:45.0435800Z   autoHideMenuBar: expected false to be true
2025-04-26T01:52:45.1438800Z   AssertionError: autoHideMenuBar: expected false to be true
2025-04-26T01:52:45.1917040Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:2386:49)
2025-04-26T01:52:45.2026080Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:52:45.2259920Z not ok 246 BrowserWindow module autoHideMenuBar state for functions can be changed
2025-04-26T01:52:45.2287570Z   autoHideMenuBar: expected false to be true
2025-04-26T01:52:45.2314990Z   AssertionError: autoHideMenuBar: expected false to be true
2025-04-26T01:52:45.2336710Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:2393:49)
2025-04-26T01:52:45.2337730Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:43.6147370Z not ok 426 BrowserWindow module window states resizable state with properties can be set with resizable constructor option
2025-04-26T01:53:43.7150620Z   maximizable: expected false to be true
2025-04-26T01:53:43.8152880Z   AssertionError: maximizable: expected false to be true
2025-04-26T01:53:43.8412840Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5228:45)
2025-04-26T01:53:43.8415100Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:43.8420100Z not ok 428 BrowserWindow module window states resizable state with functions can be set with resizable constructor option
2025-04-26T01:53:43.8422710Z   maximizable: expected false to be true
2025-04-26T01:53:43.8424570Z   AssertionError: maximizable: expected false to be true
2025-04-26T01:53:43.8426530Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5248:49)
2025-04-26T01:53:43.8429070Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:45.1113600Z not ok 441 BrowserWindow module window states (excluding Linux) representedFilename with properties can be changed
2025-04-26T01:53:45.1115230Z   expected '/Users/runner/work/electron/electron/src/~/work/electron/electron/src/a name' to deeply equal 'a name'
2025-04-26T01:53:45.1117140Z   AssertionError: expected '/Users/runner/work/electron/electron/src/~/work/electron/electron/src/a name' to deeply equal 'a name'
2025-04-26T01:53:45.1118610Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5496:44)
2025-04-26T01:53:45.1119460Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:45.2325430Z not ok 442 BrowserWindow module window states (excluding Linux) representedFilename with functions can be changed
2025-04-26T01:53:45.2326990Z   expected '/Users/runner/work/electron/electron/src/~/work/electron/electron/src/a name' to deeply equal 'a name'
2025-04-26T01:53:45.2328650Z   AssertionError: expected '/Users/runner/work/electron/electron/src/~/work/electron/electron/src/a name' to deeply equal 'a name'
2025-04-26T01:53:45.2330000Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5505:49)
2025-04-26T01:53:45.2330790Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:45.5623600Z not ok 451 BrowserWindow module window states (excluding Linux) maximizable state (property) with properties can be set with maximizable constructor option
2025-04-26T01:53:45.5645640Z   maximizable: expected true to be false
2025-04-26T01:53:45.5695990Z   AssertionError: maximizable: expected true to be false
2025-04-26T01:53:45.5724000Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5578:44)
2025-04-26T01:53:45.5746190Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:45.7575770Z not ok 452 BrowserWindow module window states (excluding Linux) maximizable state (property) with properties can be changed
2025-04-26T01:53:45.7863650Z   maximizable: expected true to be false
2025-04-26T01:53:45.7870580Z   AssertionError: maximizable: expected true to be false
2025-04-26T01:53:45.7895760Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5585:44)
2025-04-26T01:53:45.7906030Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:45.7962300Z not ok 453 BrowserWindow module window states (excluding Linux) maximizable state (property) with properties is not affected when changing other states
2025-04-26T01:53:45.7996890Z   maximizable: expected true to be false
2025-04-26T01:53:45.8027140Z   AssertionError: maximizable: expected true to be false
2025-04-26T01:53:45.8041640Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5593:44)
2025-04-26T01:53:45.8068020Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:45.8977900Z not ok 454 BrowserWindow module window states (excluding Linux) maximizable state (property) with functions can be set with maximizable constructor option
2025-04-26T01:53:45.8982880Z   isMaximizable: expected true to be false
2025-04-26T01:53:45.9004380Z   AssertionError: isMaximizable: expected true to be false
2025-04-26T01:53:45.9019320Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5611:48)
2025-04-26T01:53:45.9053240Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:46.0056920Z not ok 455 BrowserWindow module window states (excluding Linux) maximizable state (property) with functions can be changed
2025-04-26T01:53:46.0387200Z   isMaximizable: expected true to be false
2025-04-26T01:53:46.0425220Z   AssertionError: isMaximizable: expected true to be false
2025-04-26T01:53:46.0435810Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5618:48)
2025-04-26T01:53:46.0456540Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:53:46.1227070Z not ok 456 BrowserWindow module window states (excluding Linux) maximizable state (property) with functions is not affected when changing other states
2025-04-26T01:53:46.1242090Z   isMaximizable: expected true to be false
2025-04-26T01:53:46.1267270Z   AssertionError: isMaximizable: expected true to be false
2025-04-26T01:53:46.1282000Z       at Context.<anonymous> (electron/spec/api-browser-window-spec.ts:5626:48)
2025-04-26T01:53:46.1301790Z       at processImmediate (node:internal/timers:491:21)

2025-04-26T01:52:36.3191220Z not ok 62 app module accessibilitySupportEnabled property with functions can set accessibility support enabled
2025-04-26T01:52:36.3192820Z   expected true to deeply equal false
2025-04-26T01:52:36.3193580Z   AssertionError: expected true to deeply equal false
2025-04-26T01:52:36.3194580Z       at Context.<anonymous> (electron/spec/api-app-spec.ts:993:56)
2025-04-26T01:52:36.3195590Z       at processImmediate (node:internal/timers:491:21)

ckerr · 2025-04-26T17:08:19Z

I think maybe this work is getting bigger than one PR.

That feature is supported on Linux, so move the test from the "window states (excluding Linux)" section into the "window states" section.

…ted-tests warning

ckerr · 2026-04-02T21:46:40Z

closing stale

ckerr added the semver/patch backwards-compatible bug fixes label Apr 26, 2025

electron-cation Bot added the new-pr 🌱 PR opened recently label Apr 26, 2025

ckerr changed the title ~~fix: mocha/no-nested-tests~~ fix: enable mocha/no-nested-tests in eslint Apr 26, 2025

nikwen approved these changes Apr 26, 2025

View reviewed changes

This was referenced Apr 26, 2025

fix: run visibleOnAllWorkspaces tests on the right platforms #46815

Merged

fix: enable some tests that were accidentally disabled #46816

Merged

ckerr marked this pull request as draft April 26, 2025 17:53

electron-cation Bot removed the new-pr 🌱 PR opened recently label Apr 27, 2025

This was referenced Apr 27, 2025

fix: enable autoHideMenuBar tests on Linux and Windows #46818

Merged

fix: fix and enable accessibilitySupportEnabled tests #46825

Merged

ckerr force-pushed the fix/no-nested-tests branch 2 times, most recently from 1dcae15 to 7e77e1b Compare April 29, 2025 00:06

ckerr added 5 commits May 2, 2025 09:19

test: do not skip visibleOnAllWorkspaces tests on Windows

8949f35

That feature is supported on Linux, so move the test from the "window states (excluding Linux)" section into the "window states" section.

fix: nested it() calls in visibleOnAllWorkspaces specs

b713002

build: enable the mocha/no-nested-tests eslint rule

675ae83

refactor: use this.skip() instead of it.skip() to avoid @mocha/no-nes…

1e9cbc5

…ted-tests warning

fix: @mocha/no-nested-tests warnings in api-browser-window-spec.ts

35369cb

ckerr force-pushed the fix/no-nested-tests branch from 7e77e1b to 35369cb Compare May 2, 2025 14:20

ckerr closed this Apr 2, 2026

ckerr deleted the fix/no-nested-tests branch April 2, 2026 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: enable `mocha/no-nested-tests` in eslint#46807

fix: enable `mocha/no-nested-tests` in eslint#46807
ckerr wants to merge 5 commits intomainfrom
fix/no-nested-tests

ckerr commented Apr 26, 2025

Uh oh!

nikwen left a comment

Uh oh!

nikwen commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ckerr commented Apr 26, 2025

Description of Change

Checklist

Release Notes

Uh oh!

nikwen left a comment

Choose a reason for hiding this comment

Uh oh!

nikwen commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 26, 2025

Uh oh!

ckerr commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants