Skip to content

feat: support system-context-menu on Linux#46400

Closed
trop[bot] wants to merge 1 commit into35-x-yfrom
trop/35-x-y-bp-feat-support-system-context-menu-on-linux-1743498046630
Closed

feat: support system-context-menu on Linux#46400
trop[bot] wants to merge 1 commit into35-x-yfrom
trop/35-x-y-bp-feat-support-system-context-menu-on-linux-1743498046630

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop bot commented Apr 1, 2025

Backport of #45848

See that PR for details.

Notes: Added support for system-context-menu on Linux.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested review from a team and codebytere April 1, 2025 09:01
@trop trop bot mentioned this pull request Apr 1, 2025
4 tasks
@trop trop bot added 35-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Apr 1, 2025
@ckerr
Copy link
Copy Markdown
Member

ckerr commented Apr 1, 2025

Now what is this about...

npm error HEAD is now at 8246e57 chore: use alternate location for windows toolchain (#685)
npm error error Error: https://registry.yarnpkg.com/camelcase/-/camelcase-5.3.1.tgz: Request failed "403 Forbidden"
npm error     at ResponseError.ExtendableBuiltin (/usr/lib/node_modules/yarn/lib/cli.js:696:66)
npm error     at new ResponseError (/usr/lib/node_modules/yarn/lib/cli.js:802:124)
npm error     at Request.<anonymous> (/usr/lib/node_modules/yarn/lib/cli.js:66750:16)
npm error     at Request.emit (node:events:518:28)
npm error     at module.exports.Request.onRequestResponse (/usr/lib/node_modules/yarn/lib/cli.js:142287:10)
npm error     at ClientRequest.emit (node:events:518:28)
npm error     at HTTPParser.parserOnIncomingClient (node:_http_client:716:27)
npm error     at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
npm error     at TLSSocket.socketOnData (node:_http_client:558:22)
npm error     at TLSSocket.emit (node:events:518:28)
npm error Failed to install build-tools:  Error: Command "yarn install" failed with exit code 1
npm error     at throwForBadSpawn (/usr/lib/node_modules/@electron/build-tools/preinstall.js:12:11)
npm error     at install (/usr/lib/node_modules/@electron/build-tools/preinstall.js:56:5)
npm error     at Object.<anonymous> (/usr/lib/node_modules/@electron/build-tools/preinstall.js:77:1)
npm error     at Module._compile (node:internal/modules/cjs/loader:1554:14)
npm error     at Object..js (node:internal/modules/cjs/loader:1706:10)
npm error     at Module.load (node:internal/modules/cjs/loader:1289:32)
npm error     at Function._load (node:internal/modules/cjs/loader:1108:12)
npm error     at TracingChannel.traceSync (node:diagnostics_channel:322:14)
npm error     at wrapModuleLoad (node:internal/modules/cjs/loader:220:24)
npm error     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)

Looks like this might be related to npm/cli#8203. When I go to https://www.npmjs.com/search?q=camelcase manually, I get a "Sorry, you have been blocked" message.

Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux fails to build:
./../electron/shell/browser/ui/electron_desktop_window_tree_host_linux.cc:297:20: error: no member named 'supports_server_window_menus' in 'ui::OzonePlatform::PlatformRuntimeProperties'
295 | if (ui::OzonePlatform::GetInstance()
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
296 | ->GetPlatformRuntimeProperties()
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
297 | .supports_server_window_menus) {
| ^
../../electron/shell/browser/ui/electron_desktop_window_tree_host_linux.cc:298:48: error: no member named 'ShowWindowControlsMenu' in 'views::DesktopWindowTreeHostLinux'
298 | views::DesktopWindowTreeHostLinux::ShowWindowControlsMenu(
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
2 errors generated.

@codebytere codebytere closed this Apr 17, 2025
@trop trop bot deleted the trop/35-x-y-bp-feat-support-system-context-menu-on-linux-1743498046630 branch April 17, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

35-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants