-
Notifications
You must be signed in to change notification settings - Fork 16.9k
fix: extension web workers net request failing #45698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Release Notes Persisted
|
|
I have automatically backported this PR to "35-x-y", please check out #45708 |
|
I have automatically backported this PR to "32-x-y", please check out #45709 |
|
I have automatically backported this PR to "34-x-y", please check out #45710 |
|
I have automatically backported this PR to "33-x-y", please check out #45711 |
|
my bad, I accidentally merged this early 😬 lmk if folks have additional feedback for this |
Description of Change
Fixes an issue with chrome extensions in which calling
new Worker('chrome-extension://...')would fail withERR_UNKNOWN_URL_SCHEME. Below is a net log snippet of the problem.Here's the same code where it's added in Chrome: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/chrome_content_browser_client.cc;l=6210-6218;drc=798b98d70313e6a55bcf9cc85bc7ca7d42ca6d23
relates to samuelmaddock/electron-browser-shell#106
Checklist
npm testpassesRelease Notes
Notes: Fixes web worker scripts failing to load for chrome extensions.