chore: bump chromium to 133.0.6878.0 (main)#44831
Merged
Conversation
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to https://chromium-review.googlesource.com/c/v8/v8/+/6023139
The removed include is present in the original source file now, just slightly before where it was being added. 6015430: Reduce platform-like buildflags in sandbox code Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6015430
219dac7 to
6f671d6
Compare
ckerr
approved these changes
Dec 9, 2024
b4a7632 to
fb0f983
Compare
alicelovescake
approved these changes
Dec 10, 2024
deepak1556
approved these changes
Dec 10, 2024
VerteDinde
reviewed
Dec 10, 2024
| if (!electron::fuses::IsRunAsNodeEnabled()) { | ||
| CHECK(false) << "run_as_node fuse is disabled"; | ||
| return 1; | ||
| NOTREACHED() << "run_as_node fuse is disabled"; |
Member
There was a problem hiding this comment.
I could be wrong about this, but is this going to throw a hard crash if an app has the RunAsNode fuse disabled? We were returning return 1 here previously if the CHECK failed, I just want to make sure this isn't a behavior change
Member
There was a problem hiding this comment.
Good catch, I don't think there is a behavior change here. NOTREACHED without a milestone and CHECK use the same underlying destructor ~CheckError https://source.chromium.org/chromium/chromium/src/+/main:base/check.h which will abort, the return wouldn't be needed previously as well.
codebytere
approved these changes
Dec 10, 2024
jkleinsc
reviewed
Dec 10, 2024
jkleinsc
approved these changes
Dec 10, 2024
|
Release Notes Persisted
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 133.0.6878.0.
See all changes in 133.0.6852.0..133.0.6878.0
Notes: Updated Chromium to 133.0.6878.0.